-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting group.service.tags causes connect service churn #10025
Comments
@shoenig I wasn't able to replicate this on the HEAD of
|
@tgross those logs are about syncing from the Consul agent to Consul server (agent <-> catalog). The log line we're looking for occurs during Nomad's periodic sync onto Consul agent, being triggered on Nomad's periodic schedule. I understand the bug: whenever you set |
…essarily re-registered This PR fixes a bug where sidecar services would be re-registered into Consul every ~30 seconds, caused by the parent service having its tags field set and the sidecar_service tags unset. Nomad would directly compare the tags between its copy of the sidecar service definition and the tags of the sidecar service reported by Consul. This does not work, because Consul will under-the-hood set the sidecar service tags to inherit the parent service tags if the sidecar service tags are unset. The comparison then done by Nomad would not match, if the parent sidecar tags are set. Fixes #10025
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Consul logs (note 30 second interval, suggesting mis-comparison in our service reconciliation loop)
Removing the
service.tags
makes the problem go awayThe text was updated successfully, but these errors were encountered: