-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service Connect Upstream stanza doesn't match service definition in consul #10057
Comments
Hi @Ilhicas! If I look at the Also, it's not super clear to me what the difference you're intending to show between those two jobspecs... but the first one has |
Hello @tgross , what I'm saying is that consul services declaration is not matched by the one in Nomad service stanza. From consul docs: https://www.consul.io/api-docs/agent/service Proxy.Upstreams.LocalBindAddress |
Yup, it's not yet supported. See #6248. Going to close this issue as a dupe, but if you give a 👍 reaction on that issue it'll help surface it for roadmapping. |
Yup I've seen that issue before 👍 @tgross do you know if there are any plans to support it? Do you see any reason for it not being supported as of yet? Something I might be missing and why it wasn't implemented yet. I'm assuming that pr would be a lot similar to this: |
Just time and resources for the team. I'd be happy to review your PR if you're interested! |
I'm experiencing a similar issue and would really love this feature.
Deployment output: » Deploying... |
Hi @paladin-devops this feature was added to 1.1.0 check the related issue that was merged. |
Thanks @Ilhicas , I looked at your PR and then only after the fact saw that it was already included in the 1.1.0 release (and then, moments later, 1.1.1 dropped earlier today :) ). Appreciate the contribution! |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v1.0.3 (08741d9)
Consul Agent Version
consul.version | 1.9.3
consul.revision | f55da9306
Operating system and Environment details
Amazon EC2 Linux
Issue
Declaring a service stanza in nomad with consul service struct attribute for local_bind_address results in declaring an unknown attribute.
Reproduction steps
Set consul service definition as
This is a consul definition, not to be confused by Service Stanza in Nomad
All is correctly configured in consul side
Job file (if appropriate)
Set the following in nomad service stanza and will result in attribute not found
Nomad Client logs (if appropriate)
The text was updated successfully, but these errors were encountered: