consul/connect: enable setting local_bind_address in upstream

[Ilhicas]

Upstreams configuration in service->proxy->upstream stanza currently doesn't allow for the upstream local_bind_address definition

This allows to define different local_bind_addresses allowing envoy to read values from consul xds for example to bind the upstream to 127.0.0.X or others, allowing it to effectively avoid port binding in upstreams.

As an example

127.0.0.1:5432
127.0.0.2:5432

Could be used in multiple upstream stanzas without port binding issues.

This field is optional and defaults to the local_bind_address.

Closes #6248

More info on the motivations can be found at : #10057

[hashicorp-cla]

All committers have signed the CLA.

[jorgensoares]

@tgross can we have this reviewed :) thank you!

[tgross]

@jorgensoares we're in the middle of prepping the Nomad 1.0.4 release but it'll get reviewed soon.

[Ilhicas]

Hi regarding the changelog I added it there, but might not make sense, since I noticed other PR's were adding it 1.0.4 incorrectly as well.
So might have to set it elsewhere?
What is approriate here?

[shoenig]

This is looking really great @Ilhicas, thanks for the PR!

There's a block of code where we interpolate fields, and we'll want to add support for interpolating the local_bind_address also

nomad/client/taskenv/services.go

Line 131 in d164824

func interpolateConnectSidecarService(taskEnv *TaskEnv, sidecar *structs.ConsulSidecarService) {

Just that and the CHANGELOG shuffle, I think this will be good to go.

[shoenig]

Like you already mentioned, we'll want this under the 1.1.0 header now, specifically under the IMPROVEMENTS sub header

[Ilhicas]

Updated changelog

Also added LocalBindAddress to interpolation function, and updated interpolation tests

[shoenig]

LGTM; thanks @Ilhicas !

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.