Node Drain Metadata #10250
Merged
Node Drain Metadata #10250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgbaker
force-pushed
the
f-drain-metadata
branch
from
7725fe4
to
b86fd05
Compare
cgbaker
force-pushed
the
f-drain-metadata
branch
from
549e981
to
7e8a3a5
Compare
cgbaker
commented
Apr 1, 2021
| }, q) | ||
| return resp, err | ||
| } | ||
|
|
There was a problem hiding this comment.
needed a new method, followed the Jobs().RegisterOpts() pattern so we'll never need to do this again 🤞
cgbaker
commented
Apr 1, 2021
| @@ -43,13 +43,13 @@ func TestHTTP_NodesList(t *testing.T) { | |||
| } | |||
|
|
|||
| // Check for the index | |||
| if respW.HeaderMap.Get("X-Nomad-Index") == "" { | |||
| if respW.Header().Get("X-Nomad-Index") == "" { | |||
There was a problem hiding this comment.
all of these are because HeaderMap is deprecated, thought I'd clean up while I was in here
cgbaker
commented
Apr 1, 2021
cgbaker
commented
Apr 1, 2021
cgbaker
commented
Apr 1, 2021
some test comments
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9928
This persists information about the last "drain operation" in a new
Node.LastDrainfield. A "drain operation" begins when the node begins draining, and ends when the drain is complete or canceled. A new drain operation will overwrite any existingNode.LastDrainfield.In addition to native metadata about the drain operation (start time, status, end time), operators can provide additional key/value pairs about the drain operation:
.Metafield in the drain payload-metaflag or the-mgit-style shortcut (which is a shortcut forMeta.messageorMeta.cancel_message, appropriately)The work in this PR performs the following:
LastDraininstructs.Nodeandapi.NodeLastDrainLastDrainand drain metadata during drain updates-mand-meta