Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nomad Enterprise: upgrade licensing library to include fixes #10253

Closed
jrasell opened this issue Mar 29, 2021 · 2 comments · Fixed by #10258
Closed

Nomad Enterprise: upgrade licensing library to include fixes #10253

jrasell opened this issue Mar 29, 2021 · 2 comments · Fixed by #10258
Assignees
@jrasell
Labels
theme/dependencies Pull requests that update a dependency file theme/enterprise Issues related to Enterprise features type/bug
Milestone
1.1.0

Comments

@jrasell
Copy link
Member

jrasell commented Mar 29, 2021

The library used by Nomad Enterprise to perform licensing work recently merged a fix to a race condition found by @drewbailey during testing. This issue acts as a reference point for updating this library and including a changelog entry.

Nomad version

v1.0.4
@jrasell jrasell added type/bug theme/dependencies Pull requests that update a dependency file theme/enterprise Issues related to Enterprise features labels Mar 29, 2021
@jrasell jrasell self-assigned this Mar 29, 2021
jrasell added a commit that referenced this issue Mar 30, 2021
@jrasell
changelog: add entry for #10253
a82a277
@jrasell jrasell mentioned this issue Mar 30, 2021
Merged
jrasell added a commit that referenced this issue Mar 30, 2021
@jrasell
changelog: add entry for #10253
f427215
@drewbailey
Copy link
Contributor

Additional context around the race condition, If a license was applied multiple times rapidly there was a race condition that could cause a NPE. This was discovered in an automated test.

@tgross tgross added this to the 1.1.0 milestone Apr 9, 2021
tgross pushed a commit that referenced this issue Apr 12, 2021
@jrasell @tgross
changelog: add entry for #10253
ee8b8fa
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrasell jrasell

Labels
theme/dependencies Pull requests that update a dependency file theme/enterprise Issues related to Enterprise features type/bug
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

changelog: add entry for #10253 hashicorp/nomad
3 participants
@tgross @drewbailey @jrasell