Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: disallow uppercase characters in connect service names #10450

Closed
shoenig opened this issue Apr 26, 2021 · 2 comments
Closed

connect: disallow uppercase characters in connect service names #10450

shoenig opened this issue Apr 26, 2021 · 2 comments
Assignees
@shoenig
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration type/bug

Comments

@shoenig
Copy link
Member

shoenig commented Apr 26, 2021 •
edited

Using uppercase characters in Connect service names causes problems (ultimately stemming from Consul DNS and URL domains not being case sensitive). E.g. #9307 (comment)

We'll need to be super careful about backwards compatibility, as Consul does not validate this, even though it probably should.

Job submission validation would prevent #7581
@shoenig shoenig added type/bug stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration labels Apr 26, 2021
@shoenig shoenig mentioned this issue Apr 26, 2021
Closed
@shoenig shoenig self-assigned this Apr 26, 2021
shoenig added a commit that referenced this issue Apr 27, 2021
@shoenig
consul/connect: check connect group and service names for uppercase c…
fbae814 
…haracters

This PR adds job-submission validation that checks for the use of uppercase characters
in group and service names for services that make use of Consul Connect. This prevents
attempting to launch services that Consul will not validate correctly, which in turn
causes tasks to fail to launch in Nomad.

Underlying Consul issue: hashicorp/consul#6765

Closes #7581 #10450
@shoenig shoenig mentioned this issue Apr 27, 2021
Merged
shoenig added a commit that referenced this issue Apr 27, 2021
@shoenig
consul/connect: check connect group and service names for uppercase c…
27b0add 
…haracters

This PR adds job-submission validation that checks for the use of uppercase characters
in group and service names for services that make use of Consul Connect. This prevents
attempting to launch services that Consul will not validate correctly, which in turn
causes tasks to fail to launch in Nomad.

Underlying Consul issue: hashicorp/consul#6765

Closes #7581 #10450
shoenig added a commit that referenced this issue Apr 27, 2021
@shoenig
consul/connect: check connect group and service names for uppercase c…
138c056 
…haracters

This PR adds job-submission validation that checks for the use of uppercase characters
in group and service names for services that make use of Consul Connect. This prevents
attempting to launch services that Consul will not validate correctly, which in turn
causes tasks to fail to launch in Nomad.

Underlying Consul issue: hashicorp/consul#6765

Closes #7581 #10450
shoenig added a commit that referenced this issue Apr 27, 2021
@shoenig
consul/connect: check connect group and service names for uppercase c…
ce0da24 
…haracters

This PR adds job-submission validation that checks for the use of uppercase characters
in group and service names for services that make use of Consul Connect. This prevents
attempting to launch services that Consul will not validate correctly, which in turn
causes tasks to fail to launch in Nomad.

Underlying Consul issue: hashicorp/consul#6765

Closes #7581 #10450
@shoenig
Copy link
Member Author

shoenig commented Apr 27, 2021

Fixed by #10455

@shoenig shoenig closed this as completed Apr 27, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul/connect Consul Connect integration type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shoenig