-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect: disallow uppercase characters in connect service names #10450
Labels
stage/accepted
Confirmed, and intend to work on. No timeline committment though.
theme/consul/connect
Consul Connect integration
type/bug
Comments
shoenig
added a commit
that referenced
this issue
Apr 27, 2021
…haracters This PR adds job-submission validation that checks for the use of uppercase characters in group and service names for services that make use of Consul Connect. This prevents attempting to launch services that Consul will not validate correctly, which in turn causes tasks to fail to launch in Nomad. Underlying Consul issue: hashicorp/consul#6765 Closes #7581 #10450
shoenig
added a commit
that referenced
this issue
Apr 27, 2021
…haracters This PR adds job-submission validation that checks for the use of uppercase characters in group and service names for services that make use of Consul Connect. This prevents attempting to launch services that Consul will not validate correctly, which in turn causes tasks to fail to launch in Nomad. Underlying Consul issue: hashicorp/consul#6765 Closes #7581 #10450
shoenig
added a commit
that referenced
this issue
Apr 27, 2021
…haracters This PR adds job-submission validation that checks for the use of uppercase characters in group and service names for services that make use of Consul Connect. This prevents attempting to launch services that Consul will not validate correctly, which in turn causes tasks to fail to launch in Nomad. Underlying Consul issue: hashicorp/consul#6765 Closes #7581 #10450
shoenig
added a commit
that referenced
this issue
Apr 27, 2021
…haracters This PR adds job-submission validation that checks for the use of uppercase characters in group and service names for services that make use of Consul Connect. This prevents attempting to launch services that Consul will not validate correctly, which in turn causes tasks to fail to launch in Nomad. Underlying Consul issue: hashicorp/consul#6765 Closes #7581 #10450
Fixed by #10455 |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
stage/accepted
Confirmed, and intend to work on. No timeline committment though.
theme/consul/connect
Consul Connect integration
type/bug
Using uppercase characters in Connect service names causes problems (ultimately stemming from Consul DNS and URL domains not being case sensitive). E.g. #9307 (comment)
We'll need to be super careful about backwards compatibility, as Consul does not validate this, even though it probably should.
Job submission validation would prevent #7581
The text was updated successfully, but these errors were encountered: