Rotate log files at newline boundaries

[sean-]

Issue

See comment: #1047 (comment) . The following needs to happen in Write() when the file size has been exhausted.

This should scan backwards through the buffer for a \n and write/flush everything before that. Whatever comes after that last \n should be moved to the beginning of the buffer and written out on the next write (as long as the line length is less than the buffer length, in which case you need to truncate). This only needs to happen on file rotation, not on write.

[sean-]

@diptanu did #1047 fix this issue? Can this issue be closed?

[cyrilgdn]

Any news?
Our applications logs are in json format and parsed by Logstash but Nomad truncate lines when rotating log files. So these json lines are invalid...

[camerondavison]

I have the same problem as @cyrilgdn

[cyrilgdn]

@diptanu @sean- This issue seems to not be fixed currently. Is it planned for some version?

Thanks!

[schmichael]

We don't have it on our roadmap yet, but if someone wants to attempt a PR @sean-'s linked comment covers the desired behavior.

[lorenzo]

We are experiencing this as a problem because we log in json format. Is this still out of scope?

[schmichael]

@lorenzo Not out of scope. We haven't been able to prioritize it yet, sorry!

Please do vote on the parent issue with 👍 -- Github allows us to sort issues by upvotes, and we do use that when planning.

[camerondavison]

Cc: @preetapan

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.