-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase lineScanLimit in log rotation logic #4699
Comments
Hey @jippi We'd support this change, however let make it 32K. |
@jippi we would take a PR for this for the 0.9 release if you want to get this in! |
@preetapan thanks! I'll get it wrapped up today |
In case where gelf/json logging is used, its fairly easy to exceed the 16k limit, resulting in json output being cut up into multiple strings the result is invalid json lines which can create all kind of badness in the logging server This fixes hashicorp#4699 Signed-off-by: Christian Winther <jippignu@gmail.com>
PR open in #4765 |
In case where gelf/json logging is used, its fairly easy to exceed the 16k limit, resulting in json output being cut up into multiple strings the result is invalid json lines which can create all kind of badness in the logging server This fixes hashicorp#4699 Signed-off-by: Christian Winther <jippignu@gmail.com>
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
This is a follow-up on #1048 and #4282
We have some applications that are logging quite long lines of JSON (up to 25KB) - and we see our files being split across files mid-line, which causes all kind of bad error and unreadable logs in Graylog.
I would like to have lineScanLimit increased from 16K to 25K - if it doesn't affect performance in any significant way.
I'll submit the change if its okay with the Nomad team
The text was updated successfully, but these errors were encountered: