events: fix slow client connection to empty event stream #10637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
drewbailey
reviewed
May 21, 2021
drewbailey
approved these changes
May 21, 2021
There was a problem hiding this comment.
@h3yduck Thanks for the PR, I think starting off with an empty heartbeat makes sense.
notnoop
pushed a commit
that referenced
this pull request
Jun 9, 2021
* events: fix slow client connection to empty event stream * doc: fix changelog of event stream connection init
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10636
Fixed it in the API instead of the client because it probably affects all HTTP clients waiting for any response (at least HTTP headers) before returning the HTTP body to the caller. Sending an initial heartbeat shouldn't do any harm because it should already be handled by all event stream clients.