events: fix event endpoint tests to ignore heartbeats. #10647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems when this PR was raised, the Nomad CI provider was having availability issues meaning the test suite was not correctly run, thus allowing broken tests into main. The PR itself exercised test code which had not been hit before. The particular problem is when identifying whether the event received is a heartbeat; this was performed using standard Golang conditionals. Unfortunately the operator == is not defined on byte arrays, resulting in the check always returning false. To overcome this issue the code now uses the bytes.Equal function to correctly compare the data.
jrasell
added
type/bug
theme/testing
drewbailey
approved these changes
May 24, 2021
notnoop
pushed a commit
that referenced
this pull request
Jun 9, 2021
…ests events: fix event endpoint tests to ignore heartbeats.
notnoop
pushed a commit
that referenced
this pull request
Jun 9, 2021
…ests events: fix event endpoint tests to ignore heartbeats.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10637 added initial heartbeat functionality to events and it
seems when this PR was raised, the Nomad CI provider was having
availability issues meaning the test suite was not correctly run,
thus allowing broken tests into main. The PR itself exercised test
code which had not been hit before.
The particular problem is when identifying whether the event
received is a heartbeat; this was performed using standard Golang
conditionals. Unfortunately the operator == is not defined on byte
arrays, resulting in the check always returning false. To overcome
this issue the code now uses the bytes.Equal function to correctly
compare the data.