-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSI Volume Snapshot List: support secrets in the request #10640
Comments
Hi @ggriffiths! Yeah, this looks like we just missed this entirely. There's not even a field for it in the RPC endpoint. Will get this fixed. |
Sound good @tgross! I've been looking through the CSI code and can send a PR to add this feature if that would help. |
I'd be happy to review a PR! |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Proposal
CSI List Snapshots supports secrets in the request:
https://github.com/container-storage-interface/spec/blob/master/csi.proto#L1173-L1176
However, when using
nomad volume snapshot list
, there is no way to pass this secret into the request (unless I'm missing something).A possible solution could be the following workflow:
This secrets map would be passed down to the CSI driver as mentioned in the CSI spec.
Alternatively, once #7978 is implemented:
Use-cases
For CSI drivers that require a secret for a successful
nomad volume snapshot list
, this would be very helpful.Attempted Solutions
n/a - besides altering our CSI driver rules to allow for ListSnapshots without secrets.
I am happy to work on this issue if the above proposal is accepted.
The text was updated successfully, but these errors were encountered: