Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: Add secrets flag support for delete volume #10997

Closed
ggriffiths opened this issue Aug 3, 2021 · 4 comments · Fixed by #11245
Closed

CSI: Add secrets flag support for delete volume #10997

ggriffiths opened this issue Aug 3, 2021 · 4 comments · Fixed by #11245
Assignees
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage type/enhancement

Comments

@ggriffiths
Copy link
Contributor

Proposal

Add the option to provide a secret when deleting a volume, i.e.

nomad volume delete vol1 --secrets a=b,c=d

Similar to #10640

These secrets will take precedence over any stored volume secrets. They'll be combined into a single secrets map and sent to the CSI driver.

I can work on this feature if the proposal is accepted.

Use-cases

For cases when a new secret must be provided to the storage system during deletion. I.e. if a token has expired or encryption key change.

Attempted Solutions

n/a

@ggriffiths ggriffiths changed the title CSI: Add secrets support for delete volume CSI: Add secrets flag support for delete volume Aug 3, 2021
@lgfa29 lgfa29 added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage labels Aug 19, 2021
@lgfa29 lgfa29 self-assigned this Aug 19, 2021
@lgfa29 lgfa29 added this to Needs Triage in Nomad - Community Issues Triage via automation Aug 19, 2021
@lgfa29
Copy link
Contributor

lgfa29 commented Aug 19, 2021

Thank you @ggriffiths. This addition makes sense to me 🙂

@ggriffiths
Copy link
Contributor Author

Great! Will be picking up this work soon.

@lgfa29
Copy link
Contributor

lgfa29 commented Sep 23, 2021

Great! Will be picking up this work soon.

Awesome! Let us know if you need any help 😄

@tgross tgross moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Nov 8, 2021
@tgross tgross self-assigned this Feb 17, 2022
Nomad - Community Issues Triage automation moved this from Needs Roadmapping to Done Apr 5, 2022
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/storage type/enhancement
Projects
Development

Successfully merging a pull request may close this issue.

3 participants