-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using "/" to focus search box does not work in Firefox #10646
Comments
Thanks @apollo13. Can you provide a bit more information about your environment to help us debug this? I wasn't able to confirm this on macOS with Firefox 89.0 with an English/US keyboard layout. |
Mhm, Fedora 34 with Firefox 88.0.1 and german keyboard layout. (Works on Github if I hit "shift + 7" which is "/" on german layout) |
Ok, thanks. We'll get this looked at. |
I can confirm that it works after switching to an english keyboard layout. |
I think this could be fixed by changing https://github.com/hashicorp/nomad/blob/main/ui/app/components/global-search/control.js#L27 to use |
I have attached a PR that seems to fix it for me, reviews welcome. |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Typing "/" in Firefox (german keyboard layout, but that shouldn't make a difference) does not focus the search box but rather brings up Firefox's builtin quick search. See https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly#w_search -- I am not sure if there is a good way to override it.
Nomad version is 1.1.0
The text was updated successfully, but these errors were encountered: