-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service with Connect sidecar de-registered without removing sidecar first #10845
Labels
stage/accepted
Confirmed, and intend to work on. No timeline committment though.
theme/consul/connect
Consul Connect integration
type/bug
Comments
shoenig
added a commit
that referenced
this issue
Jul 8, 2021
This PR will have Nomad de-register a sidecar proxy service before attempting to de-register the parent service. Otherwise, Consul will emit a warning and an error. Fixes #10845
shoenig
added a commit
that referenced
this issue
Jul 8, 2021
This PR will have Nomad de-register a sidecar proxy service before attempting to de-register the parent service. Otherwise, Consul will emit a warning and an error. Fixes #10845
shoenig
added a commit
that referenced
this issue
Jul 8, 2021
This PR will have Nomad de-register a sidecar proxy service before attempting to de-register the parent service. Otherwise, Consul will emit a warning and an error. Fixes #10845
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
stage/accepted
Confirmed, and intend to work on. No timeline committment though.
theme/consul/connect
Consul Connect integration
type/bug
Nomad implicitly registers Connect sidecar services via the
connect.sidecar_service
stanza, and does not keep track of the sidecar service or its checks internally. When it's time to shut the task down, Nomad only de-registers the parent service (because that's all it knows about). This causes an ERROR and WARN in Consul logs - it's the root cause of hashicorp/consul#8657Nomad needs to explicitly de-register the sidecar service before de-registering the parent service to avoid making Consul unhappy.
The text was updated successfully, but these errors were encountered: