cli: -namespace should override job namespace
#10875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a jobspec doesn't include a namespace, we provide it with the default namespace, but this ends up overriding the explicit `-namespace` flag. This changeset uses the same logic as region parsing to create an order of precedence: the query string parameter (the `-namespace` flag) overrides the API request body which overrides the jobspec.
tgross
force-pushed
the
b-namespace-flag-override
branch
from
f3220b2
to
38af39e
Compare
notnoop
approved these changes
Jul 14, 2021
Merged
notnoop
pushed a commit
that referenced
this pull request
Jul 28, 2021
cli: `-namespace` should override job namespace
notnoop
pushed a commit
that referenced
this pull request
Jul 29, 2021
cli: `-namespace` should override job namespace
schmichael
added a commit
that referenced
this pull request
Aug 5, 2021
schmichael
added a commit
that referenced
this pull request
Aug 6, 2021
docs: add backward incompat note about #10875
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9893
When a jobspec doesn't include a namespace, we provide it with the default
namespace, but this ends up overriding the explicit
-namespaceflag. Thischangeset uses the same logic as region parsing to create an order of
precedence: the query string parameter (the
-namespaceflag) overrides theAPI request body which overrides the jobspec.