Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add backward incompat note about #10875 #11010

Merged
merged 1 commit into from
Aug 6, 2021
Merged

docs: add backward incompat note about #10875 #11010

merged 1 commit into from
Aug 6, 2021

Conversation

schmichael
Copy link
Member

@schmichael schmichael commented Aug 5, 2021

Fixes #11002

Is this the best way to update the changelog for old releases? It's certainly easy enough and doesn't seem to conflict with the new go-changelog driven generation. Since we always link to tags for the changelog it seems moot to update it anyway, but maybe it will help someone.

Wording advice always eagerly accepted. I'll update https://github.com/hashicorp/nomad/releases/tag/v1.1.3 once this is merged.

Screenshot of the upgrade guide:
image

@schmichael schmichael requested a review from notnoop August 5, 2021 22:10
Copy link
Contributor

@notnoop notnoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and noting it.

Is this the best way to update the changelog for old releases? It's certainly easy enough and doesn't seem to conflict with the new go-changelog driven generation

Yes. For historical edits, we need to bypass .changelog. Can you include a note about post-release modifications in contributing/CHANGELOG.md file as well? Thanks!

@schmichael
Copy link
Member Author

@schmichael schmichael merged commit 930b8b6 into main Aug 6, 2021
@schmichael schmichael deleted the docs-10875 branch August 6, 2021 15:28
@notnoop
Copy link
Contributor

notnoop commented Aug 6, 2021

hehe. I actually checked there as well but thought it only covered post-merge pre-release case. Oops!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nomad 1.1.3 Issues with Handling Namespaces
2 participants