-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event stream doesn't respect namespace=* #10903
Labels
stage/accepted
Confirmed, and intend to work on. No timeline committment though.
theme/events
Issues related to events
type/bug
Comments
isabeldepapel
added a commit
that referenced
this issue
Jul 21, 2021
This fixes a bug in the event stream API where it currently interprets namespace=* as an actual namespace, not a wildcard. Fixes #10903
isabeldepapel
added a commit
that referenced
this issue
Jul 23, 2021
This fixes a bug in the event stream API where it currently interprets namespace=* as an actual namespace, not a wildcard. When Nomad parses incoming requests, it sets namespace to default if not specified, which means the request namespace will never be an empty string, which is what the event subscription was checking for. This changes the conditional logic to check for a wildcard namespace instead of an empty one. It also updates some event tests to include the default namespace in the subscription to match current behavior. Fixes #10903
isabeldepapel
added a commit
that referenced
this issue
Sep 2, 2021
This fixes a bug in the event stream API where it currently interprets namespace=* as an actual namespace, not a wildcard. When Nomad parses incoming requests, it sets namespace to default if not specified, which means the request namespace will never be an empty string, which is what the event subscription was checking for. This changes the conditional logic to check for a wildcard namespace instead of an empty one. It also updates some event tests to include the default namespace in the subscription to match current behavior. Fixes #10903
schmichael
pushed a commit
that referenced
this issue
Oct 5, 2021
This fixes a bug in the event stream API where it currently interprets namespace=* as an actual namespace, not a wildcard. When Nomad parses incoming requests, it sets namespace to default if not specified, which means the request namespace will never be an empty string, which is what the event subscription was checking for. This changes the conditional logic to check for a wildcard namespace instead of an empty one. It also updates some event tests to include the default namespace in the subscription to match current behavior. Fixes #10903
schmichael
pushed a commit
that referenced
this issue
Oct 5, 2021
This fixes a bug in the event stream API where it currently interprets namespace=* as an actual namespace, not a wildcard. When Nomad parses incoming requests, it sets namespace to default if not specified, which means the request namespace will never be an empty string, which is what the event subscription was checking for. This changes the conditional logic to check for a wildcard namespace instead of an empty one. It also updates some event tests to include the default namespace in the subscription to match current behavior. Fixes #10903
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
stage/accepted
Confirmed, and intend to work on. No timeline committment though.
theme/events
Issues related to events
type/bug
Issue
When passing
namespace=*
to the event stream API, the*
is interpreted as a namespace, not a wildcardReproduction steps
Expected Result
events from all namespaces are included
Actual Result
no events are returned
The text was updated successfully, but these errors were encountered: