Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event stream doesn't respect namespace=* #10903

Closed
drewbailey opened this issue Jul 15, 2021 · 1 comment · Fixed by #10935
Closed

Event stream doesn't respect namespace=* #10903

drewbailey opened this issue Jul 15, 2021 · 1 comment · Fixed by #10935
Assignees
@isabeldepapel
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/events Issues related to events type/bug

Comments

@drewbailey
Copy link
Contributor

Issue

When passing namespace=* to the event stream API, the * is interpreted as a namespace, not a wildcard

Reproduction steps

Expected Result

events from all namespaces are included

Actual Result

no events are returned
@drewbailey drewbailey added type/bug theme/events Issues related to events labels Jul 15, 2021
@jrasell jrasell added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Jul 16, 2021
@jrasell jrasell added this to Needs Triage in Nomad - Community Issues Triage via automation Jul 16, 2021
@jrasell jrasell moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Jul 16, 2021
@isabeldepapel isabeldepapel self-assigned this Jul 16, 2021
isabeldepapel added a commit that referenced this issue Jul 21, 2021
@isabeldepapel
events: fix wildcard namespace handling
2dc3d6d 
This fixes a bug in the event stream API where it currently interprets
namespace=* as an actual namespace, not a wildcard.

Fixes #10903
isabeldepapel added a commit that referenced this issue Jul 23, 2021
@isabeldepapel
events: fix wildcard namespace handling
91f05cb 
This fixes a bug in the event stream API where it currently interprets
namespace=* as an actual namespace, not a wildcard. When Nomad parses
incoming requests, it sets namespace to default if not specified, which
means the request namespace will never be an empty string, which is what
the event subscription was checking for. This changes the conditional
logic to check for a wildcard namespace instead of an empty one.

It also updates some event tests to include the default namespace in the
subscription to match current behavior.

Fixes #10903
@isabeldepapel isabeldepapel mentioned this issue Jul 23, 2021
Merged
Nomad - Community Issues Triage automation moved this from Needs Roadmapping to Done Sep 2, 2021
isabeldepapel added a commit that referenced this issue Sep 2, 2021
@isabeldepapel
events: fix wildcard namespace handling (#10935)
1eea499 
This fixes a bug in the event stream API where it currently interprets
namespace=* as an actual namespace, not a wildcard. When Nomad parses
incoming requests, it sets namespace to default if not specified, which
means the request namespace will never be an empty string, which is what
the event subscription was checking for. This changes the conditional
logic to check for a wildcard namespace instead of an empty one.

It also updates some event tests to include the default namespace in the
subscription to match current behavior.

Fixes #10903
schmichael pushed a commit that referenced this issue Oct 5, 2021
@isabeldepapel @schmichael
events: fix wildcard namespace handling (#10935)
266bd03 
This fixes a bug in the event stream API where it currently interprets
namespace=* as an actual namespace, not a wildcard. When Nomad parses
incoming requests, it sets namespace to default if not specified, which
means the request namespace will never be an empty string, which is what
the event subscription was checking for. This changes the conditional
logic to check for a wildcard namespace instead of an empty one.

It also updates some event tests to include the default namespace in the
subscription to match current behavior.

Fixes #10903
schmichael pushed a commit that referenced this issue Oct 5, 2021
@isabeldepapel @schmichael
events: fix wildcard namespace handling (#10935)
25fc419 
This fixes a bug in the event stream API where it currently interprets
namespace=* as an actual namespace, not a wildcard. When Nomad parses
incoming requests, it sets namespace to default if not specified, which
means the request namespace will never be an empty string, which is what
the event subscription was checking for. This changes the conditional
logic to check for a wildcard namespace instead of an empty one.

It also updates some event tests to include the default namespace in the
subscription to match current behavior.

Fixes #10903
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isabeldepapel isabeldepapel

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/events Issues related to events type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

events: fix wildcard namespace handling hashicorp/nomad
3 participants
@drewbailey @jrasell @isabeldepapel