log_rotate_max_files is only checked on exceeding log_rotate_duration or log_rotate_bytes

[h3yduck]

Nomad version

Nomad v1.1.2 (60638a086ef9630e2a9ba1e237e8426192a44244)

Operating system and Environment details

Tested on macOS Big Sur 11.1 (20C69), but it should apply to all operating systems/environments.

Issue

log_rotate_max_files is only applied if:

1. There is a log line written and
2. log_rotate_duration or log_rotate_bytes is exceeded.

Reproduction steps

Given a client.hcl with contents of:

log_file             = "/tmp/log/"
log_rotate_max_files = 7

When

for i in {1..20}; do nomad agent -config client.hcl & sleep 5 && kill $!; done

is ran then

ls /tmp/log|wc -l

should return

Expected Result

8 (log_rotate_max_files specifies the maximum number of older log file archives to keep, not including the log file currently being written)

Actual Result

20

[h3yduck]

Fixed by #11070.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.