client: fix deletion of archive log files based on log_rotate_max_files

[h3yduck]

Fixes #10912

Added pruning of old archive files on the first write (without having a file open = on starting the client).

[h3yduck]

@drewbailey could you guys please take a look at this anytime soon?

[lgfa29]

Hi @h3yduck 👋

Sorry for the delay on getting this reviewed. I think this problem has been mitigated by #11070 where we realized that the behaviour of log_file was actually wrong and Nomad was generating timestamped log files even for the active one.

Could you check if this solves the problem for you? That patch was released in Nomad v1.1.4.

Thanks!

[h3yduck]

Hi @lgfa29 👋

Thank you very much for the notification 🙂 Yes, the change fixes the bug as well 🎉

On the other hand, it introduces behavior that is problematic for us: if the number/size of the log files isn't exceeded and the client is restarted, the previous logs are lost (because the previously active log file isn't archived to a timestamped file and the contents are overridden with the logs of the restarted client). Anyways, that is a completely different problem, I will open an issue for that and I'm closing this one.

Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.