-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent behaviour adding the same job twice or updating without any change. #10981
Comments
This can also be simulated by going to |
@notnoop Thanks for the quick fix! Will it be backported to 1.1.3 or will there be a new release (say 1.1.4) ? |
The change should be out in 1.1.4 (as well as 1.0.10), due to be released very soon. In my testing, this issue seems to only impact planning, but it doesn't seem to actually perform in-place updates. For example, when retrying your job in the CLI, I noticed that while
|
1.1.3 had a bug where task.VolumeMounts will be an empty slice instead of nil. Eventually, it gets canonicalized and is set to `nil`, but it seems to confuse dry-run planning. The regression was introduced in https://github.com/hashicorp/nomad/pull/10855/files#diff-56b3c82fcbc857f8fb93a903f1610f6e6859b3610a4eddf92bad9ea27fdc85ecL1028-R1037 . Curiously, it's the only place where `len(apiTask.VolumeMounts)` check was dropped. I assume it was dropped accidentally. Fixes #10981
1.1.3 had a bug where task.VolumeMounts will be an empty slice instead of nil. Eventually, it gets canonicalized and is set to `nil`, but it seems to confuse dry-run planning. The regression was introduced in https://github.com/hashicorp/nomad/pull/10855/files#diff-56b3c82fcbc857f8fb93a903f1610f6e6859b3610a4eddf92bad9ea27fdc85ecL1028-R1037 . Curiously, it's the only place where `len(apiTask.VolumeMounts)` check was dropped. I assume it was dropped accidentally. Fixes #10981
1.1.3 had a bug where task.VolumeMounts will be an empty slice instead of nil. Eventually, it gets canonicalized and is set to `nil`, but it seems to confuse dry-run planning. The regression was introduced in https://github.com/hashicorp/nomad/pull/10855/files#diff-56b3c82fcbc857f8fb93a903f1610f6e6859b3610a4eddf92bad9ea27fdc85ecL1028-R1037 . Curiously, it's the only place where `len(apiTask.VolumeMounts)` check was dropped. I assume it was dropped accidentally. Fixes #10981
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
1.1.3
Operating system and Environment details
Ubuntu 21.04 arm64
Issue
I am trying to run the same job (Task1 see below) twice on nomad. Nomad still shows it is being updated (see pic1). This happens only for some tasks and seems inconsistent (see Pic1 and Pic2).
Task1:
Pic1:
![image](https://user-images.githubusercontent.com/19410501/127770187-4811fddb-aa8a-4d57-bad5-500b003c355e.png)
Task2:
Pic2:
![image](https://user-images.githubusercontent.com/19410501/127771426-7a2ee5bb-9867-4db8-a080-966a1b2e6a73.png)
See the difference between pic1 and pic2.
Also when deploying using ansible (twice), I see some jobs changed while others remained the same.
![image](https://user-images.githubusercontent.com/19410501/127770580-03bd2d8d-1e18-4ab1-8977-0bf47f86b0a7.png)
Previously (probably 0.10), this did not happen.
The text was updated successfully, but these errors were encountered: