Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update x/sys to support go 1.17 #11065

Merged
merged 3 commits into from
Aug 25, 2021
Merged

Update x/sys to support go 1.17 #11065

merged 3 commits into from
Aug 25, 2021

Conversation

roopakv
Copy link
Contributor

@roopakv roopakv commented Aug 19, 2021

Updates x/sys to support go 1.17 which is blocking brew go 1.17

more context here: Homebrew/homebrew-core#83413

please cut a release after merging this.

@vercel vercel bot temporarily deployed to Preview – nomad August 19, 2021 06:34 Inactive
@roopakv roopakv mentioned this pull request Aug 19, 2021
Closed
@roopakv
Copy link
Contributor Author

roopakv commented Aug 23, 2021

@jrasell could you please take a look at this, or help find the right person to review

@jrasell jrasell self-assigned this Aug 25, 2021
@jrasell jrasell self-requested a review August 25, 2021 09:27
@jrasell jrasell added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/dependencies Pull requests that update a dependency file type/enhancement labels Aug 25, 2021
jrasell
jrasell reviewed Aug 25, 2021
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @roopakv and thanks for this, it looks good. Would you be able to push a follow up commit to add a changelog entry as per this documentation? I believe this would fall under improvement.

@vercel vercel bot temporarily deployed to Preview – nomad August 25, 2021 14:36 Inactive
jrasell
jrasell approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roopakv I went ahead and pushed the changelog entry so I can merge this shortly. Thanks!

@jrasell jrasell merged commit 5f5ec95 into hashicorp:main Aug 25, 2021
@roopakv
Copy link
Contributor Author

roopakv commented Aug 25, 2021

@jrasell thank you so much. could you also please cut a new release so that brew is fully unblocked

@roopakv roopakv deleted the roopak/xsys branch August 25, 2021 17:16
@jrasell
Copy link
Member

jrasell commented Aug 25, 2021

@roopakv we won't be cutting a release specifically for this, however, we are close to our next timing so it shouldn't be too long.

notnoop pushed a commit that referenced this pull request Aug 26, 2021
@roopakv @jrasell
Update x/sys to support go 1.17 (#11065)
250268a 
Co-authored-by: James Rasell <jrasell@hashicorp.com>
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jrasell jrasell jrasell approved these changes

Assignees

@jrasell jrasell

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/dependencies Pull requests that update a dependency file type/enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roopakv @jrasell