-
-
Notifications
You must be signed in to change notification settings - Fork 12.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.17 #83413
go 1.17 #83413
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Try building them with go 1.17 and fix them if they're broken. |
@SMillerDev some of them are flakes i guess, cos I got it to pass locally. and that is why I was confused |
You can help by trying to make the tests less flaky so they don't show up on the next Go PR, if you can. |
This comment has been minimized.
This comment has been minimized.
A number of those failures seem to be related to golang/go#46763 Specifically the comment:
Referring to golang/go#45702 |
Big Sur failures are the same as on Mojave. Catalina failures are also the same except for |
Updating x/sys so that this supports go 1.17. Once this is in here we will need to cut a new release. More context: Homebrew/homebrew-core#83413 See also ooni/probe#1737 Co-authored-by: Simone Basso <bassosimone@gmail.com>
Updating x/sys so that this supports go 1.17. Once this is in here we will need to cut a new release. More context: Homebrew/homebrew-core#83413 See also ooni/probe#1737 Co-authored-by: Simone Basso <bassosimone@gmail.com> This is a cherry-pick of 143949a Conflicts: go.mod
Would it be possible for you all to kind of pin previous versions of Golang? Like |
Also, CC @codefromthecrypt for |
I will try the envoy ones locally (as I have Big Sur) and try to help triage upstream as necessary |
both
|
The problem here is that go can't be upgraded until all things that depend on it can. The impact is that end users can't install go 1.17 While there are other projects blocking this, Envoy is also. Specifically, homebrew builds the envoy 1.19 and 1.18 latest version, and they don't work with go 1.17. IIUC, there is some part of how Envoy uses protos that ends up requiring go. @keith or maybe @phlax will know better. I don't personally have the experience to know exactly what is going on and how to fix it. Once this is sorted, whatever is implied to make this work would ideally be cherry-picked into these branches so that patches aren't needed forever. PS I opened this some time back as I noticed in general the Envoy team are unaware of homebrew. At least raising a PR during a release will help keep folks on the project team aware of knock-on effects on ecosystems mentioned in the install page. envoyproxy/envoy#17500 Hope this helps! |
Here's how I will verify on amd64 and arm64 Big Sur: $ cd /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core
$ gh pr checkout 83413
$ brew install --build-from-source go
$ brew install --build-from-source envoy |
revised my comment, can skip the remote bottle download by |
here's the failure on envoy with Big Sur arm64 (M1). amd64 is still chugging
|
Best to ignore M1 support for Envoy atm until envoyproxy/envoy#16482 is resolved |
On darwin/amd64 building envoy local worked, so it may indeed be a transient or worker related issue ± |bump-go-1.17 {1} ✓| → brew install --build-from-source envoy
Updating Homebrew...
==> Auto-updated Homebrew!
Updated 1 tap (homebrew/core).
==> New Formulae
airspyhf
==> Downloading https://github.com/envoyproxy/envoy/commit/3b49166dc0841b045799e
Already downloaded: /Users/adrian/Library/Caches/Homebrew/downloads/9cc321c489d93019439b089e49a1221bfcdc27016debe90f699e20737b667c3d--3b49166dc0841b045799e2c37bdf1ca9de98d5b1.patch
==> Cloning https://github.com/envoyproxy/envoy.git
Updating /Users/adrian/Library/Caches/Homebrew/envoy--git
==> Checking out tag v1.19.0
HEAD is now at 68fe53a88 release: v1.19.0 (#17320)
HEAD is now at 68fe53a88 release: v1.19.0 (#17320)
==> Patching
==> Applying 3b49166dc0841b045799e2c37bdf1ca9de98d5b1.patch
patching file bazel/envoy_internal.bzl
==> /usr/local/opt/bazelisk/bin/bazelisk build --compilation_mode=opt --curses=n
🍺 /usr/local/Cellar/envoy/1.19.0: 319 files, 118.9MB, built in 68 minutes 35 seconds |
Envoy build process pulls Go 1.15.5 by Bazel (https://github.com/envoyproxy/envoy/blob/main/bazel/dependency_imports.bzl#L14), so it isn't relevant to system Go. M1 support should be ignored until Envoy supports that. |
@lizan that's great news. I'll remove the go dependency from the envoy formulae and if they work raise a PR so that people aren't distracted by this in the future. |
Great; thanks for the clarification! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created with
brew bump-formula-pr
.resource
blocks may require updates.