Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.17 #83517

Closed
wants to merge 1 commit into from
Closed

go 1.17 #83517

wants to merge 1 commit into from

Conversation

jef
Copy link
Contributor

@jef jef commented Aug 18, 2021

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Log
% brew test Formula/go.rb                       
==> Testing go
==> /usr/local/Cellar/go/1.17/bin/go fmt hello.go
==> /usr/local/Cellar/go/1.17/bin/go run hello.go
==> /usr/local/Cellar/go/1.17/bin/go build hello.go

% brew audit --strict ./Formula/go.rb 
Error: Failed to load cask: ./Formula/go.rb
Cask 'go' is unreadable: wrong constant name #<Class:0x00007fa73e977e48>
Warning: Treating ./Formula/go.rb as a formula.

% go version     
go version go1.17 darwin/amd64

@BrewTestBot BrewTestBot added CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner labels Aug 18, 2021
@jef
Copy link
Contributor Author

jef commented Aug 18, 2021

Not sure if I need to update the bottles here or the gobootstrap.

@carlocab
Copy link
Member

Duplicate of #83413

@carlocab carlocab marked this as a duplicate of #83413 Aug 18, 2021
@carlocab carlocab closed this Aug 18, 2021
@jef jef deleted the chore/update-go-1.17 branch August 18, 2021 19:12
@jef
Copy link
Contributor Author

jef commented Aug 18, 2021

Crap, I thought I searched and didn't see it. Sorry about that.

Thanks!

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-linux-self-hosted Build on Linux self-hosted runner outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants