modd: deprecate #84056
Closed
modd: deprecate #84056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
reviewed
Aug 27, 2021
Formula/modd.rb
Outdated
| def install | ||
| ENV["GOPATH"] = buildpath | ||
| ENV["GO111MODULE"] = "auto" | ||
| (buildpath/"src/github.com/cortesi/modd").install buildpath.children | ||
| cd "src/github.com/cortesi/modd" do | ||
| system "go", "build", *std_go_args, "./cmd/modd" | ||
| system "dep", "ensure", "-vendor-only" |
There was a problem hiding this comment.
I don't think we want to go back to dep, I'd rather deprecate the formula and let it use an older go version until it's eventually removed.
There was a problem hiding this comment.
works for me, it's disappointing because master still sees commits just no tagged release in 2+ years. maybe that's common in the go community
SMillerDev
approved these changes
Aug 28, 2021
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?To use go 1.17 for #83413,
x/sysneeds to be upgraded (see cortesi/modd#103). However, the patch isn't directly usable as the latest release isn't using modules and we've had no response from cortesi/modd#96.I first tried applying cortesi/devd@4ab3fc9, but that fails due to a symlink:
any other alternatives here?