Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build nomad anymore due to broken dependencies #11237

Closed
apollo13 opened this issue Sep 29, 2021 · 5 comments · Fixed by #11249
Closed

Cannot build nomad anymore due to broken dependencies #11237

apollo13 opened this issue Sep 29, 2021 · 5 comments · Fixed by #11249
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/dependencies Pull requests that update a dependency file type/bug
Milestone

Comments

@apollo13
Copy link
Contributor

When trying to build nomad now I get:

go: github.com/hashicorp/go-discover@v0.0.0-20200812215701-c4b85f6ed31f requires
	github.com/tencentcloud/tencentcloud-sdk-go@v3.0.83+incompatible: reading github.com/tencentcloud/tencentcloud-sdk-go/go.mod at revision v3.0.83: unknown revision v3.0.83

This was fixed in go-discover hashicorp/go-discover@fccf997 -- might need an update?

@jrasell
Copy link
Member

jrasell commented Oct 1, 2021

Hi @apollo13 and thanks. Agreed we should probably update the go-discover library. I wasn't able to reproduce the error, however, on Darwin or Linux using current main. Could you provide the commands you're running and any other information that could help reproduce this error?

@apollo13
Copy link
Contributor Author

apollo13 commented Oct 1, 2021 via email

@jrasell jrasell added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/dependencies Pull requests that update a dependency file labels Oct 1, 2021
@jrasell jrasell added this to the 1.2.0 milestone Oct 1, 2021
@apollo13
Copy link
Contributor Author

apollo13 commented Oct 4, 2021

Thank you!

@apollo13
Copy link
Contributor Author

apollo13 commented Oct 4, 2021

@jrasell To actually make this compile I still need to do the following additions:

diff --git a/go.mod b/go.mod
index 2fa05de3e..3b2d088bc 100644
--- a/go.mod
+++ b/go.mod
@@ -7,7 +7,7 @@ replace (
        github.com/NYTimes/gziphandler => github.com/NYTimes/gziphandler v1.0.0
        github.com/apparentlymart/go-textseg/v12 => github.com/apparentlymart/go-textseg/v12 v12.0.0
 
-       github.com/hashicorp/go-discover => github.com/hashicorp/go-discover v0.0.0-20200812215701-c4b85f6ed31f
+       github.com/hashicorp/go-discover => github.com/hashicorp/go-discover v0.0.0-20210818145131-c573d69da192
        github.com/hashicorp/hcl => github.com/hashicorp/hcl v1.0.1-0.20201016140508-a07e7d50bbee
        github.com/hashicorp/nomad/api => ./api
        github.com/kr/pty => github.com/kr/pty v1.1.5
diff --git a/go.sum b/go.sum
index f9ee95cd5..b404760f7 100644
--- a/go.sum
+++ b/go.sum
@@ -374,6 +374,8 @@ github.com/hashicorp/go-cty-funcs v0.0.0-20200930094925-2721b1e36840 h1:kgvybwEe
 github.com/hashicorp/go-cty-funcs v0.0.0-20200930094925-2721b1e36840/go.mod h1:Abjk0jbRkDaNCzsRhOv2iDCofYpX1eVsjozoiK63qLA=
 github.com/hashicorp/go-discover v0.0.0-20200812215701-c4b85f6ed31f h1:7WFMVeuJQp6BkzuTv9O52pzwtEFVUJubKYN+zez8eTI=
 github.com/hashicorp/go-discover v0.0.0-20200812215701-c4b85f6ed31f/go.mod h1:D4eo8/CN92vm9/9UDG+ldX1/fMFa4kpl8qzyTolus8o=
+github.com/hashicorp/go-discover v0.0.0-20210818145131-c573d69da192 h1:eje2KOX8Sf7aYPiAsLnpWdAIrGRMcpFjN/Go/Exb7Zo=
+github.com/hashicorp/go-discover v0.0.0-20210818145131-c573d69da192/go.mod h1:3/4dzY4lR1Hzt9bBqMhBzG7lngZ0GKx/nL6G/ad62wE=
 github.com/hashicorp/go-envparse v0.0.0-20180119215841-310ca1881b22 h1:HTmDIaSN95gbdMyrsbNiXSdW4fbGctGQwEqv0H7OhDQ=
 github.com/hashicorp/go-envparse v0.0.0-20180119215841-310ca1881b22/go.mod h1:/NlxCzN2D4C4L2uDE6ux/h6jM+n98VFQM14nnCIfHJU=
 github.com/hashicorp/go-gatedio v0.5.0 h1:Jm1X5yP4yCqqWj5L1TgW7iZwCVPGtVc+mro5r/XX7Tg=
@@ -739,6 +741,8 @@ github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/
 github.com/syndtr/gocapability v0.0.0-20170704070218-db04d3cc01c8/go.mod h1:hkRG7XYTFWNJGYcbNJQlaLq0fg1yr4J4t/NcTQtrfww=
 github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635 h1:kdXcSzyDtseVEc4yCz2qF8ZrQvIDBJLl4S1c3GCXmoI=
 github.com/syndtr/gocapability v0.0.0-20200815063812-42c35b437635/go.mod h1:hkRG7XYTFWNJGYcbNJQlaLq0fg1yr4J4t/NcTQtrfww=
+github.com/tencentcloud/tencentcloud-sdk-go v1.0.162 h1:8fDzz4GuVg4skjY2B0nMN7h6uN61EDVkuLyI2+qGHhI=
+github.com/tencentcloud/tencentcloud-sdk-go v1.0.162/go.mod h1:asUz5BPXxgoPGaRgZaVm1iGcUAuHyYUo1nXqKa83cvI=
 github.com/tencentcloud/tencentcloud-sdk-go v3.0.83+incompatible h1:8uRvJleFpqLsO77WaAh2UrasMOzd8MxXrNj20e7El+Q=
 github.com/tencentcloud/tencentcloud-sdk-go v3.0.83+incompatible/go.mod h1:0PfYow01SHPMhKY31xa+EFz2RStxIqj6JFAJS+IkCi4=
 github.com/tj/go-spin v1.1.0 h1:lhdWZsvImxvZ3q1C5OIB7d72DuOwP4O2NdBg9PyzNds=

apollo13 added a commit to apollo13/nomad that referenced this issue Oct 5, 2021
apollo13 added a commit to apollo13/nomad that referenced this issue Oct 5, 2021
apollo13 added a commit to apollo13/nomad that referenced this issue Oct 5, 2021
lgfa29 pushed a commit that referenced this issue Oct 14, 2021
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/dependencies Pull requests that update a dependency file type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants