Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: persist node drain settings #11368

Merged
merged 3 commits into from
Oct 22, 2021
Merged

ui: persist node drain settings #11368

merged 3 commits into from
Oct 22, 2021

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Oct 21, 2021

Persist drain settings in local storage so users don't have to set them again while draining multiple nodes.

Closes #11123

@github-actions
Copy link

github-actions bot commented Oct 21, 2021

Ember Asset Size action

As of 0eaa94a

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +724 B +147 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Oct 21, 2021

Ember Test Audit comparison

main 0eaa94a change
passes 1194 1194 0
failures 0 0 0
flaky 0 1 +1
duration 9m 16s 575ms 8m 43s 680ms -32s 895ms

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on main:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group

Ember Test Audit detected these flaky tests on b58f27a:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group
  • Integration | Component | TopoViz: clicking on an allocation in a deeply nested TopoViz::Node will associate sibling allocations with curves
  • Integration | Component | TopoViz: when the count of sibling allocations is high enough relative to the node count, curves are not rendered
  • Integration | Utility | exec-socket-xterm-adapter: resizing the window passes a resize message through the socket

}

module('Acceptance | client detail', function(hooks) {
setupApplicationTest(hooks);
setupMirage(hooks);

hooks.beforeEach(function() {
window.localStorage.clear();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a learning question. Why wouldn't we put this into a clean up hook?

hooks.afterEach(function() {
  window.localStorage.clear();
}

Isn't that more in line with what we're trying to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mostly just two different perspectives. One says "make sure we have a clean environment before running the test", the other says "make sure we clean-up after ourselves before we leave".

The only difference is on the edges of the test cases. with an afterEach, the first test may run with in a dirty environment, and with beforeEach the last test case may leave some side effects behind.

To avoid these problems it's important to keep tests consistent, and all other tests modules that use localStorage clears it with beforeEach.

Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only 2 small non-blocking comments.

@github-actions
Copy link

Ember Test Audit flaky tests

Ember Test Audit detected these flaky tests on 0eaa94a:

  • Acceptance | task group detail: /jobs/:id/:task-group second breadcrumb should link to the job for the task group

@lgfa29 lgfa29 merged commit f729ba5 into main Oct 22, 2021
@lgfa29 lgfa29 deleted the f-ui-persist-drain branch October 22, 2021 14:51
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: Remember drain settings on client page
2 participants