Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: emit max_memory metric #11490

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

danishprakash
Copy link
Contributor

Closes #10838

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @danishprakash!

We're in the release candidate window so this won't get merged until 1.2.0 GA (early next week, most likely). I can add the changelog item for this when I do that.

@tgross tgross added this to the 1.2.1 milestone Nov 10, 2021
@tgross tgross merged commit e70b0b7 into hashicorp:main Nov 17, 2021
Nomad - Community Issues Triage automation moved this from In Progress to Done Nov 17, 2021
@tgross
Copy link
Member

tgross commented Nov 17, 2021

Changelog will be in #11517

@tgross tgross mentioned this pull request Nov 17, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

metrics don't emit max_memory
2 participants