core: allow setting and propagation of eval priority on job de/registration #11532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the Nomad job register and deregister RPCs to accept an updated option set which includes eval priority. This param is optional and override the use of the job priority to set the eval priority. In order to ensure all evaluations as a result of the request use the same eval priority, the priority is shared to the allocReconciler and deploymentWatcher. This creates a new distinction between eval priority and job priority.
The Nomad agent HTTP API has been modified to allow setting the eval priority on job update and delete. To keep consistency with the current v1 API, job update accepts this as a payload param; job delete accepts this as a query param. Any user supplied value is validated within the agent HTTP handler removing the need to pass invalid requests to the server.
The register and deregister opts functions now all for setting the eval priority on requests. The change includes a small change to the DeregisterOpts function which handles nil opts. This brings the function inline with the RegisterOpts.
tgross
reviewed
Nov 18, 2021
There was a problem hiding this comment.
Overall this looks great @jrasell! The way you broke up the PR into commits with good messages really helped expedite review here too. Thanks!
I've left a few comments/questions but I think the only thing that's potentially a blocker is my concern about deployments during an upgrade.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows setting the evaluation priority on job registration, update, and deregistration. In the event an override parameter is set, it will be validate to be within the 1-100 (inclusive) range. All evaluations triggered as a direct result of the job change request will inherit the override evaluation priority. This has meant the evaluation priority needs to be passed to the allocation reconciler and deployment watcher, as the eval priority and job priority are now distinctly different properties. If the operator does not set an override, the job priority is used which is consistent with the current behaviour.
I've added a demo to my dev-mess repo which details one way to test this change and see the behaviour.
Each commit contains additional commentary where needed.
closes #11434