-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: allow setting and propagation of eval priority on job de/registration #11532
Merged
Commits on Nov 18, 2021
-
core: allow setting and propagation of eval priority.
This change modifies the Nomad job register and deregister RPCs to accept an updated option set which includes eval priority. This param is optional and override the use of the job priority to set the eval priority. In order to ensure all evaluations as a result of the request use the same eval priority, the priority is shared to the allocReconciler and deploymentWatcher. This creates a new distinction between eval priority and job priority.
Configuration menu - View commit details
-
Copy full SHA for 3eeded7 - Browse repository at this point
Copy the full SHA 3eeded7View commit details -
http: allow setting eval priority in job update and delete.
The Nomad agent HTTP API has been modified to allow setting the eval priority on job update and delete. To keep consistency with the current v1 API, job update accepts this as a payload param; job delete accepts this as a query param. Any user supplied value is validated within the agent HTTP handler removing the need to pass invalid requests to the server.
Configuration menu - View commit details
-
Copy full SHA for db84a1f - Browse repository at this point
Copy the full SHA db84a1fView commit details -
api: allow setting eval priority on job update and delete.
The register and deregister opts functions now all for setting the eval priority on requests. The change includes a small change to the DeregisterOpts function which handles nil opts. This brings the function inline with the RegisterOpts.
Configuration menu - View commit details
-
Copy full SHA for b0dd99d - Browse repository at this point
Copy the full SHA b0dd99dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6463de5 - Browse repository at this point
Copy the full SHA 6463de5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0989ad - Browse repository at this point
Copy the full SHA c0989adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75809b0 - Browse repository at this point
Copy the full SHA 75809b0View commit details
Commits on Nov 19, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e606ca6 - Browse repository at this point
Copy the full SHA e606ca6View commit details -
Configuration menu - View commit details
-
Copy full SHA for b041cda - Browse repository at this point
Copy the full SHA b041cdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 572da5d - Browse repository at this point
Copy the full SHA 572da5dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.