Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Add var args to plan output. #11631

Merged
merged 3 commits into from
Dec 7, 2021
Merged

cli: Add var args to plan output. #11631

merged 3 commits into from
Dec 7, 2021

Conversation

Liraim
Copy link
Contributor

@Liraim Liraim commented Dec 7, 2021

Fixes for issue #11616.

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 7, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel vercel bot temporarily deployed to Preview – nomad December 7, 2021 11:01 Inactive
@vercel vercel bot temporarily deployed to Preview – nomad December 7, 2021 12:03 Inactive
@tgross tgross self-requested a review December 7, 2021 13:50
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Dec 7, 2021
@tgross tgross moved this from Needs Triage to In Progress in Nomad - Community Issues Triage Dec 7, 2021
tgross
tgross requested changes Dec 7, 2021
View reviewed changes
command/job_plan.go Outdated Show resolved Hide resolved
@tgross tgross added this to the 1.2.3 milestone Dec 7, 2021
@Liraim @tgross
Remove additional space after added args.
5bace94 
Co-authored-by: Tim Gross <tgross@hashicorp.com>
@vercel vercel bot temporarily deployed to Preview – nomad December 7, 2021 14:33 Inactive
tgross
tgross approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've added a changelog entry and once CI is done this will get merged. Thanks again!

@vercel vercel bot temporarily deployed to Preview – nomad December 7, 2021 14:39 Inactive
@tgross tgross merged commit 2a8f032 into hashicorp:main Dec 7, 2021
Nomad - Community Issues Triage automation moved this from In Progress to Done Dec 7, 2021
@tgross tgross mentioned this pull request Dec 8, 2021
Closed
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tgross tgross tgross approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Nomad - Community Issues Triage
Archived in project
Nomad - Community Issues Triage
Done
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Liraim @hashicorp-cla @tgross