add titles to breadcrumbs #11687
Merged
add titles to breadcrumbs #11687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All breadcrumbs do not need a title property because some views drill down by using a tab-based UI (e.g. CSI volumes and the Job Overview) The goal is to help us identify breadcrumbs that are non-descriptive (i.e. breadcrumbs that display as an ID).
Ember Asset Size actionAs of c628d7f Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
Ember Test Audit flaky testsEmber Test Audit detected these flaky tests on e-ui/breadcrumbs-service:
Ember Test Audit detected these flaky tests on c628d7f:
|
lgfa29
approved these changes
Dec 16, 2021
| } | ||
|
|
||
| li::before { | ||
| font-size: x-large; |
There was a problem hiding this comment.
This changes causes a small move in the file explorer breadcrumb. We could limit this to .breadcrumb.is-large elements
lgfa29
added a commit
that referenced
this pull request
Dec 18, 2021
lgfa29
added a commit
that referenced
this pull request
Dec 18, 2021
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles creating titles to breadcrumbs.
Actual
Mock
Special Case for Parent Jobs per the RFC
