Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add titles to breadcrumbs #11687

Merged
merged 6 commits into from
Dec 17, 2021
Merged

add titles to breadcrumbs #11687

merged 6 commits into from
Dec 17, 2021

Commits on Dec 16, 2021

  1. feat: add title to default breadcrumb component

    @ChaiWithJai
    ChaiWithJai committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    e9d44c2 View commit details
    Browse the repository at this point in the history

  2. style: add styling for title on breadcrumbs

    @ChaiWithJai
    ChaiWithJai committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    c6aae0c View commit details
    Browse the repository at this point in the history

  3. refact: add title to breadcrumb generator 

    All breadcrumbs do not need a title property because some views
drill down by using a tab-based UI (e.g. CSI volumes and the Job Overview)

The goal is to help us identify breadcrumbs that are non-descriptive (i.e.
breadcrumbs that display as an ID).
    @ChaiWithJai
    ChaiWithJai committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    aed6fd3 View commit details
    Browse the repository at this point in the history

  4. feat: handle title behavior for job breadcrumb

    @ChaiWithJai
    ChaiWithJai committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    03a0f41 View commit details
    Browse the repository at this point in the history

  5. style: centering and spacing for titled breadcrumbs

    @ChaiWithJai
    ChaiWithJai committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    b58df56 View commit details
    Browse the repository at this point in the history

  6. fix: test specs should expect to receive breadcrumb titles

    @ChaiWithJai
    ChaiWithJai committed Dec 16, 2021
    Configuration menu
    Copy the full SHA
    c628d7f View commit details
    Browse the repository at this point in the history