Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: set world-readable permissions on copied resolv.conf #11856

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Jan 14, 2022

Fixes #11845

When we copy the system DNS to a task's resolv.conf, we should set
the permissions as world-readable so that unprivileged users within
the task can read it.

When we copy the system DNS to a task's `resolv.conf`, we should set
the permissions as world-readable so that unprivileged users within
the task can read it.
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix 👍

@tgross tgross merged commit 77287b0 into main Jan 14, 2022
@tgross tgross deleted the b-resolv-conf-permissions branch January 14, 2022 17:25
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
When we copy the system DNS to a task's `resolv.conf`, we should set
the permissions as world-readable so that unprivileged users within
the task can read it.
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
When we copy the system DNS to a task's `resolv.conf`, we should set
the permissions as world-readable so that unprivileged users within
the task can read it.
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
When we copy the system DNS to a task's `resolv.conf`, we should set
the permissions as world-readable so that unprivileged users within
the task can read it.
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
When we copy the system DNS to a task's `resolv.conf`, we should set
the permissions as world-readable so that unprivileged users within
the task can read it.
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
When we copy the system DNS to a task's `resolv.conf`, we should set
the permissions as world-readable so that unprivileged users within
the task can read it.
lgfa29 pushed a commit that referenced this pull request Jan 17, 2022
When we copy the system DNS to a task's `resolv.conf`, we should set
the permissions as world-readable so that unprivileged users within
the task can read it.
lgfa29 pushed a commit that referenced this pull request Jan 18, 2022
When we copy the system DNS to a task's `resolv.conf`, we should set
the permissions as world-readable so that unprivileged users within
the task can read it.
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants