Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: set world-readable permissions on copied resolv.conf #11856

Merged
merged 1 commit into from
Jan 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/11856.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
drivers: Fixed a bug where the `resolv.conf` copied from the system was not readable to unprivileged processes within the task
```
9 changes: 2 additions & 7 deletions drivers/shared/resolvconf/mount.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,10 @@ func copySystemDNS(dest string) error {
}
defer in.Close()

out, err := os.Create(dest)
content, err := io.ReadAll(in)
if err != nil {
return err
}
defer func() {
out.Sync()
out.Close()
}()

_, err = io.Copy(out, in)
return err
return os.WriteFile(dest, content, 0644)
}