-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add related evaluations to API #11858
Comments
Feedback from UI sync - could we also return a value to show if there are more evals beyond the requested chain? I get the 10 previous and I am told there are 10+ with a bool. |
Also, I think from the UI's perspective, adding this information to the standard GET command is preferable to a new endpoint. |
Can we make the Example: Some challenges we foresee at the moment are:
|
I think I'd prefer that to making a new endpoint entirely. That way it's just another field to filter on in the state store query and we can filter on multiple dimensions at once. That'll cut down on implementation work but also let us optimize by using all the same filters that we could on the "parent" eval like it's namespace.
It already should; if there's no |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Proposal
In the Nomad UI, it would be helpful to show a list of related evaluations for a specific evaluation. Not just the Next, Previous, and Blocked eval IDs, but multiple evaluations in the linked list and their ID's + statuses.
Currently, the only way to surface this information is to make a sequence of API calls based on the Next/Prev ID values.
Ideally, we could get this infomation in a single call.
Since the chain of evals might be very long, it probably makes sense to limit the chain size via some param.
I currently can think of two ways to accomplish this:
/v1/evaluation/:id/related
related_count=5
that would include a new field or fields that should the chain of related params. So instead of just NextEval/PreviousEval, it might include NextEvals (plural) and PreviousEvals (plural) and include their IDs, statuses.The latter might be preferable from the UI's standpoint, just to cut down on necessary calls, but I think both would work well.
Use-cases
This would allow users to have a simple way to trace an Evaluation back to its source, jump to related evaluations, and figure out the latest status in a chain of evals.
This could support a UI that allows for that. Something like this:
Attempted Solutions
As mentioned above, we could make multiple API calls or try to get a subset of the chain based on the evals index. Neither of which is a great option.
The text was updated successfully, but these errors were encountered: