Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: use HTTP headers for passing CSI secrets #12144

Merged
merged 2 commits into from
Mar 1, 2022
Merged

Conversation

tgross
Copy link
Member

@tgross tgross commented Feb 28, 2022

Fixes #11308
Unblocks #10997 #11245

  • Use a header for passing the CSI secrets rather than querystring params.
  • Deprecate the existing (*CSIVolumes) ListSnapshots()` HTTP API method.
  • Updates the CLI for consistency across uses of the -secret flag.

Comment on lines +163 to 165
// DEPRECATED: will be removed in Nomad 1.4.0
// ListSnapshots lists external storage volume snapshots.
func (v *CSIVolumes) ListSnapshots(pluginID string, secrets string, q *QueryOptions) (*CSISnapshotListResponse, *QueryMeta, error) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to reviewers: this was originally shipped in 1.2.0 with #10848 but we missed that we had an existing ListSnapshotRequest ready to use for it. It's unlikely there are many callers for this outside of maybe the Terraform provider but we should clean this up before we have any.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually after a major release I go over api changes and update the Terraform provider if necessary.

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes. but LGMT

.changelog/12144.txt Show resolved Hide resolved
Comment on lines +163 to 165
// DEPRECATED: will be removed in Nomad 1.4.0
// ListSnapshots lists external storage volume snapshots.
func (v *CSIVolumes) ListSnapshots(pluginID string, secrets string, q *QueryOptions) (*CSISnapshotListResponse, *QueryMeta, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually after a major release I go over api changes and update the Terraform provider if necessary.

api/csi.go Outdated Show resolved Hide resolved
website/content/docs/commands/volume/snapshot-list.mdx Outdated Show resolved Hide resolved
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use HTTP headers for passing CSI secrets
2 participants