Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make getAllPidsByCgroup work with cgroups v2 #12351

Closed
shoenig opened this issue Mar 22, 2022 · 1 comment · Fixed by #12419
Closed

make getAllPidsByCgroup work with cgroups v2 #12351

shoenig opened this issue Mar 22, 2022 · 1 comment · Fixed by #12419
Assignees
@shoenig
Labels
theme/cgroups cgroups issues type/bug

Comments

@shoenig
Copy link
Member

shoenig commented Mar 22, 2022

Again in shoring up cpuset tests, some driver tests fail on cgroups v2 because getAllPidsByCgroup assumes cgroups v1.

Will Skip these out for now and come back.
@shoenig shoenig self-assigned this Mar 22, 2022
@shoenig shoenig mentioned this issue Mar 22, 2022
Merged
shoenig added a commit that referenced this issue Mar 31, 2022
@shoenig
raw_exec: make raw exec driver work with cgroups v2
cf909fa 
This PR adds support for the raw_exec driver on systems with only cgroups v2.

The raw exec driver is able to use cgroups to manage processes. This happens
only on Linux, when exec_driver is enabled, and the no_cgroups option is not
set. The driver uses the freezer controller to freeze processes of a task,
issue a sigkill, then unfreeze. Previously the implementation assumed cgroups
v1, and now it also supports cgroups v2.

There is a bit of refactoring in this PR, but the fundamental design remains
the same.

Closes #12351 #12348
@shoenig shoenig mentioned this issue Mar 31, 2022
Merged
shoenig added a commit that referenced this issue Mar 31, 2022
@shoenig
raw_exec: make raw exec driver work with cgroups v2
c8d2402 
This PR adds support for the raw_exec driver on systems with only cgroups v2.

The raw exec driver is able to use cgroups to manage processes. This happens
only on Linux, when exec_driver is enabled, and the no_cgroups option is not
set. The driver uses the freezer controller to freeze processes of a task,
issue a sigkill, then unfreeze. Previously the implementation assumed cgroups
v1, and now it also supports cgroups v2.

There is a bit of refactoring in this PR, but the fundamental design remains
the same.

Closes #12351 #12348
shoenig added a commit that referenced this issue Apr 4, 2022
@shoenig
raw_exec: make raw exec driver work with cgroups v2
06a3872 
This PR adds support for the raw_exec driver on systems with only cgroups v2.

The raw exec driver is able to use cgroups to manage processes. This happens
only on Linux, when exec_driver is enabled, and the no_cgroups option is not
set. The driver uses the freezer controller to freeze processes of a task,
issue a sigkill, then unfreeze. Previously the implementation assumed cgroups
v1, and now it also supports cgroups v2.

There is a bit of refactoring in this PR, but the fundamental design remains
the same.

Closes #12351 #12348
shoenig added a commit that referenced this issue Apr 4, 2022
@shoenig
raw_exec: make raw exec driver work with cgroups v2
be7ec8d 
This PR adds support for the raw_exec driver on systems with only cgroups v2.

The raw exec driver is able to use cgroups to manage processes. This happens
only on Linux, when exec_driver is enabled, and the no_cgroups option is not
set. The driver uses the freezer controller to freeze processes of a task,
issue a sigkill, then unfreeze. Previously the implementation assumed cgroups
v1, and now it also supports cgroups v2.

There is a bit of refactoring in this PR, but the fundamental design remains
the same.

Closes #12351 #12348
@github-actions
Copy link

github-actions bot commented Oct 9, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
theme/cgroups cgroups issues type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

raw_exec: make raw exec driver work with cgroups v2 hashicorp/nomad
1 participant
@shoenig