Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: fix timestamp from volume snapshot responses #12352

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 22, 2022

Fixes #10670

Listing snapshots was incorrectly returning nanoseconds instead of
seconds, and formatting of timestamps both list and create snapshot
was treating the timestamp as though it were nanoseconds instead of
seconds. This resulted in create timestamps always being displayed as
zero values.

Fix the unit conversion error in the command line and the incorrect
extraction in the CSI plugin client code. Beef up the unit tests to
make sure this code is actually exercised.


After this patch, the CLI outputs look like the following.

Listing snapshots. Note these sort the reverse way I'd expect and want, but we'll come back to that in a separate patch.

$ nomad volume snapshot list -plugin aws-ebs0 -per-page 5
Snapshot ID             Volume ID     Size     Create Time                Ready?
snap-08391e1d0fe151035  vol-ffffffff  8.0 GiB  2017-02-08T07:14:09-05:00  true
snap-0d67b4f5b5355ba43  vol-ffffffff  8.0 GiB  2017-02-03T14:52:02-05:00  true
snap-0a65a2caffea0382e  vol-ffffffff  8.0 GiB  2017-02-03T14:09:45-05:00  true
snap-046281ab24d756c50  vol-033ca269  8.0 GiB  2017-02-02T18:57:19-05:00  true
snap-00de7e12fd08987c4  vol-0bf7e5b6  8.0 GiB  2017-02-02T18:44:49-05:00  true

Creating a snapshot:

$ nomad volume create ./input/ebs-volume0.hcl
Created external volume vol-0c7afdbcfa7a9d715 with ID ebs-vol[0]

$ nomad volume snapshot create 'ebs-vol[0]' tim-test-snapshot2
Snapshot ID             Volume ID     Size    Create Time                Ready?
snap-01b2cfe069ef183aa  vol-0c7afdbc  10 GiB  2022-03-22T16:52:15-04:00  false

@tgross
Copy link
Member Author

tgross commented Mar 22, 2022

(Switched this back to draft b/c there's a go.mod change that came up that I'd like to see if I can avoid here.) Fixed.

Listing snapshots was incorrectly returning nanoseconds instead of
seconds, and formatting of timestamps both list and create snapshot
was treating the timestamp as though it were nanoseconds instead of
seconds. This resulted in create timestamps always being displayed as
zero values.

Fix the unit conversion error in the command line and the incorrect
extraction in the CSI plugin client code. Beef up the unit tests to
make sure this code is actually exercised.
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; nanos are easier in scientific notation

command/volume_snapshot_list.go Outdated Show resolved Hide resolved
Co-authored-by: Seth Hoenig <seth.a.hoenig@gmail.com>
@vercel vercel bot temporarily deployed to Preview – nomad March 23, 2022 14:39 Inactive
@tgross tgross merged commit fe65d80 into main Mar 23, 2022
@tgross tgross deleted the b-csi-snapshot-create-time branch March 23, 2022 14:39
@lgfa29 lgfa29 added the backport/1.1.x backport to 1.1.x release line label Apr 19, 2022
@lgfa29 lgfa29 added the backport/1.2.x backport to 1.1.x release line label Apr 19, 2022
lgfa29 pushed a commit that referenced this pull request Apr 19, 2022
Listing snapshots was incorrectly returning nanoseconds instead of
seconds, and formatting of timestamps both list and create snapshot
was treating the timestamp as though it were nanoseconds instead of
seconds. This resulted in create timestamps always being displayed as
zero values.

Fix the unit conversion error in the command line and the incorrect
extraction in the CSI plugin client code. Beef up the unit tests to
make sure this code is actually exercised.
lgfa29 pushed a commit that referenced this pull request Apr 19, 2022
Listing snapshots was incorrectly returning nanoseconds instead of
seconds, and formatting of timestamps both list and create snapshot
was treating the timestamp as though it were nanoseconds instead of
seconds. This resulted in create timestamps always being displayed as
zero values.

Fix the unit conversion error in the command line and the incorrect
extraction in the CSI plugin client code. Beef up the unit tests to
make sure this code is actually exercised.
@shoenig shoenig mentioned this pull request Jun 2, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line theme/storage type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSI Snapshot create time not populated
3 participants