Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of CSI: fix timestamp from volume snapshot responses into release/1.1.x #12693

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #12352 to be assessed for backporting due to the inclusion of the label backport/1.1.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


Fixes #10670

Listing snapshots was incorrectly returning nanoseconds instead of
seconds, and formatting of timestamps both list and create snapshot
was treating the timestamp as though it were nanoseconds instead of
seconds. This resulted in create timestamps always being displayed as
zero values.

Fix the unit conversion error in the command line and the incorrect
extraction in the CSI plugin client code. Beef up the unit tests to
make sure this code is actually exercised.


After this patch, the CLI outputs look like the following.

Listing snapshots. Note these sort the reverse way I'd expect and want, but we'll come back to that in a separate patch.

$ nomad volume snapshot list -plugin aws-ebs0 -per-page 5
Snapshot ID             Volume ID     Size     Create Time                Ready?
snap-08391e1d0fe151035  vol-ffffffff  8.0 GiB  2017-02-08T07:14:09-05:00  true
snap-0d67b4f5b5355ba43  vol-ffffffff  8.0 GiB  2017-02-03T14:52:02-05:00  true
snap-0a65a2caffea0382e  vol-ffffffff  8.0 GiB  2017-02-03T14:09:45-05:00  true
snap-046281ab24d756c50  vol-033ca269  8.0 GiB  2017-02-02T18:57:19-05:00  true
snap-00de7e12fd08987c4  vol-0bf7e5b6  8.0 GiB  2017-02-02T18:44:49-05:00  true

Creating a snapshot:

$ nomad volume create ./input/ebs-volume0.hcl
Created external volume vol-0c7afdbcfa7a9d715 with ID ebs-vol[0]

$ nomad volume snapshot create 'ebs-vol[0]' tim-test-snapshot2
Snapshot ID             Volume ID     Size    Create Time                Ready?
snap-01b2cfe069ef183aa  vol-0c7afdbc  10 GiB  2022-03-22T16:52:15-04:00  false

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@lgfa29
Copy link
Contributor

lgfa29 commented Apr 19, 2022

Manually backported

@lgfa29 lgfa29 closed this Apr 19, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants