Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI: allow namespace field to be passed in volume spec #12400

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 29, 2022

Fixes #11196.

Use the volume spec's namespace field to override the value of the
-namespace and NOMAD_NAMESPACE field, just as we do with job spec.

Use the volume spec's `namespace` field to override the value of the
`-namespace` and `NOMAD_NAMESPACE` field, just as we do with job spec.
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross merged commit b075e0a into main Mar 29, 2022
@tgross tgross deleted the csi-volume-spec-namespace branch March 29, 2022 18:46
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying a namespace within a CSI volume registration file
2 participants