remove pre-0.9 driver code and related E2E test #12791
Conversation
This test exercises upgrades between 0.8 and Nomad versions greater than 0.9. We have not supported 0.8.x in a very long time and in any case the test has been marked to skip because the downloader doesn't work.
There was a problem hiding this comment.
How would you feel about killing some code along with it? https://github.com/hashicorp/nomad/search?q=Pre09
I think these tests are what cover that code, so it'd be nice to remove it instead of leaving it untested.
If that feels too sketchy I'm fine leaving it in place and just dropping these tests since it's already unsupported.
Works for me. I'll knock that out and add a note to the upgrade notes before we cut rc1. |
|
I've left client/state/08types.go in place because remember digging into that when doing the CSI client state update, and I don't want to rush trying to remove that for this release. |
tgross
changed the title
tgross
changed the title
| before 0.9 without rescheduling. Jobs that were created before 0.9 but | ||
| have had tasks replaced over time after 0.9 will operate normally | ||
| during the upgrade. |
There was a problem hiding this comment.
Don't we upgrade state on agent restart? So this should only affect folks trying to upgrade directly from Nomad 0.9 to Nomad 1.3 (which I have no interest in supporting).
There was a problem hiding this comment.
Oops, no we do not because reattachment is totally different.
There was a problem hiding this comment.
Right, that's what I'm trying to say here but maybe not making as clear as I could. Like if you created the job in 0.8 but you've cycled out all the tasks in the following years because you've upgraded in-between, you're fine.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This test exercises upgrades between 0.8 and Nomad versions greater
than 0.9. We have not supported 0.8.x in a very long time and in any
case the test has been marked to skip because the downloader doesn't
work.
Part of ongoing work to remove the old E2E framework code (ref #12383)