Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: move example test to use go's stdlib test runner #12383

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 25, 2022

Our E2E "framework" has a bunch of features around test discovery and
standing up infra that were never completed or fully used, and we
ended up building out a large test suite that ignored all that in lieu
of Terraform-provided infrastructure for the last couple years.

This changeset is a proposal (and demonstration) for gradually
migrating our E2E tests off the framework code so that developers can
write fairly ordinary golang stdlib testing tests.


$ go test -v .
=== RUN   TestExample
=== RUN   TestExample/TestExample_Simple
    example_test.go:24: Logging TestExample/TestExample_Simple
=== RUN   TestExample/TestExample_WithCleanup
    example_test.go:33: Logging TestExample/TestExample_WithCleanup
--- PASS: TestExample (3.08s)
    --- PASS: TestExample/TestExample_Simple (0.08s)
    --- PASS: TestExample/TestExample_WithCleanup (2.80s)
PASS
ok      github.com/hashicorp/nomad/e2e/example  3.353s

@vercel vercel bot temporarily deployed to Preview – nomad March 25, 2022 14:56 Inactive
@tgross tgross changed the title E2E: move example test to use golangs stdlib test runner E2E: move example test to use go's stdlib test runner Mar 25, 2022
@tgross tgross added the theme/testing Test related issues label Mar 25, 2022
@vercel vercel bot temporarily deployed to Preview – nomad March 25, 2022 15:46 Inactive
Our E2E "framework" has a bunch of features around test discovery and
standing up infra that were never completed or fully used, and we
ended up building out a large test suite that ignored all that in lieu
of Terraform-provided infrastructure for the last couple years.

This changeset is a proposal (and demonstration) for gradually
migrating our E2E tests off the framework code so that developers can
write fairly ordinary golang stdlib testing tests.
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/testing Test related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants