Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E: move volume mounts test to use golang's stdlib test runner #12788

Merged
merged 1 commit into from
Apr 26, 2022
Merged

E2E: move volume mounts test to use golang's stdlib test runner #12788

merged 1 commit into from
Apr 26, 2022

Conversation

tgross
Copy link
Member

@tgross tgross commented Apr 26, 2022 •
edited
Loading

Part of ongoing work to remove the old E2E framework code (ref #12383)

Results:

$ go test -v ./e2e/volumes
=== RUN   TestVolumeMounts
--- PASS: TestVolumeMounts (29.02s)
PASS
ok      github.com/hashicorp/nomad/e2e/volumes  29.988s

@tgross
E2E: move volume mounts test to use golang's stdlib test runner
6f9ebc4 
Part of ongoing work to remove the old E2E framework code.
@tgross tgross added theme/testing Test related issues theme/cleanup labels Apr 26, 2022
DerekStrickland
DerekStrickland approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@DerekStrickland DerekStrickland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and easy to read! LGTM

@tgross tgross merged commit 059c89d into main Apr 26, 2022
@tgross tgross deleted the e2e-volumes-port-to-go-test branch April 26, 2022 18:28
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DerekStrickland DerekStrickland DerekStrickland approved these changes

@jrasell jrasell Awaiting requested review from jrasell

Assignees
No one assigned
Labels
theme/cleanup theme/testing Test related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgross @DerekStrickland