Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update redis example version #12927

Closed
shoenig opened this issue May 9, 2022 · 1 comment · Fixed by #13044
Closed

docs: update redis example version #12927

shoenig opened this issue May 9, 2022 · 1 comment · Fixed by #13044
Assignees
@shoenig @mikenomitch
Labels
theme/docs Documentation issues and enhancements type/enhancement
Milestone
1.4.0

Comments

@shoenig
Copy link
Member

shoenig commented May 9, 2022

We make use of redis:3.2 in a lot of examples in docs and in nomad job init.

https://hub.docker.com/_/redis doesn't even list redis 3 as a supported version anymore.

Update the docs and reference job(s) to redis:7, which should be a supported version for quite some time.
@shoenig shoenig added type/enhancement theme/docs Documentation issues and enhancements labels May 9, 2022
shoenig added a commit that referenced this issue May 17, 2022
@shoenig
cli: update default redis and use nomad service discovery
d91e416 
Closes #12927
Closes #12958

This PR updates the version of redis used in our examples from 3.2 to 7.
The old version is very not supported anymore, and we should be setting
a good example by using a supported version.

The long-form example job is now fixed so that the service stanza uses
nomad as the service discovery provider, and so now the job runs without
a requirement of having Consul running and configured.
@shoenig shoenig mentioned this issue May 17, 2022
Merged
@shoenig shoenig added this to the 1.4.0 milestone May 17, 2022
Merged
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

@mikenomitch mikenomitch

Labels
theme/docs Documentation issues and enhancements type/enhancement
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

cli: update default redis and use nomad service discovery hashicorp/nomad
2 participants
@shoenig @mikenomitch