Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Status Command Does Not Respect -namespace Wildcard #13660

Closed
MikaelHashiCorp opened this issue Jul 8, 2022 · 1 comment
Closed
Assignees
Labels
hcc/cst Admin - internal stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/deployments type/bug

Comments

@MikaelHashiCorp
Copy link

Nomad version

v1.3.1
v1.3.2-dev (c0f2f7e+CHANGES)

Operating system and Environment details

Ubuntu 20.04.4 LTS

Issue

When passing in the -namespace="*" flag into the "deployment status" command, it returns a error instead of returning the proper deployment. Error message:

Error retrieving deployment: Deployment ID "8faa0e1a" matched no deployments

Reproduction steps

Get a deployment ID:

nomad deployment list

Get its info using the status command:

nomad deployment status -namespace="default" 8faa0e1a

Note it returns the info:

ID          = 8faa0e1a
Job ID      = grafana
Job Version = 0
Status      = successful
Description = Deployment completed successfully

Deployed
Task Group  Desired  Placed  Healthy  Unhealthy  Progress Deadline
grafana     1        1       1        0          2022-07-07T00:04:08Z

Try to get its info using a namespace wildcard:

nomad deployment status -namespace="*" "

Note it says "matched no deployment":

Error retrieving deployment: Deployment ID "8faa0e1a" matched no deployments

Expected Result

The wildcard value should allow getting deployment info from any namespace.

Actual Result

An error is returned instead:

2022-07-08_15-07-17

@tgross
Copy link
Member

tgross commented Jul 9, 2022

A quick glance at the code suggests that the Deployment.List RPC has the same bug as was fixed for Eval.List in #13530. We should probably survey the other List RPC endpoints and make sure they're correct as well.

@tgross tgross added theme/deployments stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Jul 9, 2022
@tgross tgross added this to Needs Triage in Nomad - Community Issues Triage via automation Jul 9, 2022
@tgross tgross removed this from Needs Triage in Nomad - Community Issues Triage Jul 9, 2022
@tgross tgross added this to the 1.3.x milestone Jul 9, 2022
@mikenomitch mikenomitch modified the milestones: 1.3.x, 1.4.0 Jul 22, 2022
@mmcquillan mmcquillan removed this from the 1.3.x milestone Aug 31, 2022
@jrasell jrasell assigned jrasell and Juanadelacuesta and unassigned jrasell Apr 4, 2023
@mikenomitch mikenomitch added the hcc/cst Admin - internal label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hcc/cst Admin - internal stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/deployments type/bug
Projects
None yet
Development

No branches or pull requests

6 participants