Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace cache #13679

Merged
merged 11 commits into from
Jul 11, 2022
Merged

Remove namespace cache #13679

merged 11 commits into from
Jul 11, 2022

Conversation

philrenaud
Copy link
Contributor

@philrenaud philrenaud commented Jul 11, 2022

Removes the "namespace" query parameter between routes (jobs, optimize, volumes) to keep that filter isolated (you may not want to filter across all entity types).

This more closely aligns to the behaviour of our current Evaluations page

@philrenaud philrenaud self-assigned this Jul 11, 2022
@philrenaud philrenaud marked this pull request as ready for review July 11, 2022 17:02
@philrenaud philrenaud requested a review from lgfa29 July 11, 2022 17:02
@philrenaud philrenaud added this to the 1.3.2 milestone Jul 11, 2022
@philrenaud philrenaud added the backport/1.3.x backport to 1.3.x release line label Jul 11, 2022
@github-actions
Copy link

github-actions bot commented Jul 11, 2022

Ember Asset Size action

As of 96729bf

Files that got Smaller 🎉:

File raw gzip
nomad-ui.js -1.16 kB -254 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Jul 11, 2022

Ember Test Audit comparison

main 96729bf change
passes 1374 1372 -2
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

lgfa29 added a commit that referenced this pull request Jul 11, 2022
Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pushed a commit to fix the changelog entry since it was overwriting a previous one.

Base automatically changed from 13142-evaluations-ui-permissions-issue-with-namespaces to main July 11, 2022 20:42
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.3.x backport to 1.3.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants