Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Allow wildcard for Evaluations API into release/1.3.x #13697

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #13530 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


UI:

  • Fixes an issue where the namespace=<namespace> query parameter was not being observed by the Evaluations route
  • Remove persistence of the passed namespace (from jobs, volumes, etc.) moved to Remove namespace cache #13679

API:

  • Adds a failing test that checks to try to get evals with a valid token on the * namespace
  • Fixes the API return to check for AllNamespacesSentinel before sending ErrPermissionDenied

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/13142-evaluations-ui-permissions-issue-with-namespaces/weekly-helping-tarpon branch 2 times, most recently from 14670d1 to c0a58ef Compare July 11, 2022 20:42
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 113a937 into release/1.3.x Jul 11, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/13142-evaluations-ui-permissions-issue-with-namespaces/weekly-helping-tarpon branch July 11, 2022 20:42
@github-actions
Copy link

Ember Test Audit comparison

release/1.3.x c0a58ef change
passes 1288 1288 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants