Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document "Deployments" in the Concepts section #13731

Closed
wimax-grapl opened this issue Jul 12, 2022 · 5 comments · Fixed by #14750
Closed

document "Deployments" in the Concepts section #13731

wimax-grapl opened this issue Jul 12, 2022 · 5 comments · Fixed by #14750
Assignees
Labels
theme/deployments theme/docs Documentation issues and enhancements type/enhancement

Comments

@wimax-grapl
Copy link

wimax-grapl commented Jul 12, 2022

Proposal

I'd like to see a minimal description of a Deployment on https://www.nomadproject.io/docs/concepts/architecture that compare-contrasts it to, say, an Allocation.

Use-cases

My use case is the following: I was trying to reverse-engineer the job-success monitoring that goes on when you nomad job run, which was introduced here:
#10661
It relies on the Deployment api, which is not well documented publicly. Or rather, you'll get stuff like "The /deployment endpoints are used to query for and interact with deployments.", which skirts telling you what concept this represents!

While it looks like it's a collection of Allocation IDs, I'm genuinely just unsure.

Attempted Solutions

this is a documentation request

@schmichael schmichael added theme/website nomadproject.io infrastructure issues and enhancements theme/docs Documentation issues and enhancements and removed theme/website nomadproject.io infrastructure issues and enhancements labels Jul 13, 2022
@schmichael schmichael added this to Needs Triage in Nomad - Community Issues Triage via automation Jul 13, 2022
@schmichael schmichael moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Jul 13, 2022
@schmichael
Copy link
Member

Great idea! We're hoping to have a little docs sprint soon, and this is on our TODO list.

@wimax-grapl
Copy link
Author

wimax-grapl commented Jul 14, 2022 via email

@tgross tgross changed the title nomadproject.io documentation request: "Deployments" in the Concepts section document "Deployments" in the Concepts section Jul 28, 2022
@tgross
Copy link
Member

tgross commented Jul 28, 2022

Notes from dupe #10581:

The deployment logic is currently hand-wavy and interactions: canaries, deployment timeouts, node health, etc. Create concept documentation for deployments that contains diagrams showing the state transitions that occur during deployments.

@tgross
Copy link
Member

tgross commented Sep 29, 2022

Fixed by #14750

@tgross tgross moved this from Needs Roadmapping to In Progress in Nomad - Community Issues Triage Sep 29, 2022
Nomad - Community Issues Triage automation moved this from In Progress to Done Oct 3, 2022
@github-actions
Copy link

github-actions bot commented Feb 1, 2023

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/deployments theme/docs Documentation issues and enhancements type/enhancement
Projects
Development

Successfully merging a pull request may close this issue.

3 participants