Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a title to the evals route #13865

Merged
merged 1 commit into from
Jul 20, 2022
Merged

Add a title to the evals route #13865

merged 1 commit into from
Jul 20, 2022

Conversation

philrenaud
Copy link
Contributor

image

@philrenaud philrenaud self-assigned this Jul 20, 2022
@philrenaud philrenaud linked an issue Jul 20, 2022 that may be closed by this pull request
Missing breadcrumb for Evaluations page #13686
Closed
@github-actions
Copy link

Ember Asset Size action

As of bd0e879

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +165 B 0 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

Ember Test Audit comparison

main bd0e879 change
passes 1372 1372 0
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

@philrenaud philrenaud merged commit e8bfd9d into main Jul 20, 2022
@philrenaud philrenaud deleted the 13686-missing-breadcrumb-for-evaluations-page branch July 20, 2022 17:28
lgfa29 added a commit that referenced this pull request Jul 22, 2022
@lgfa29
changelog: add entry for #13865 and #13866
e160e36
@lgfa29 lgfa29 added the backport/1.3.x backport to 1.3.x release line label Jul 22, 2022
lgfa29 added a commit that referenced this pull request Jul 22, 2022
@lgfa29
changelog: add entry for #13865 and #13866 (#13901)
01a62db
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jul 22, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiWithJai ChaiWithJai ChaiWithJai approved these changes

@lgfa29 lgfa29 Awaiting requested review from lgfa29

Assignees

@philrenaud philrenaud

Labels
backport/1.3.x backport to 1.3.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing breadcrumb for Evaluations page
3 participants
@philrenaud @ChaiWithJai @lgfa29