Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] constraint distinct #1387

Closed
camerondavison opened this issue Jul 5, 2016 · 10 comments
Closed

[feature] constraint distinct #1387

camerondavison opened this issue Jul 5, 2016 · 10 comments

Comments

@camerondavison
Copy link
Contributor

camerondavison commented Jul 5, 2016

I like the distinct_hosts constraint, but I would really like if it were more generic. This way it could be distinct racks or distinct aws availability zones. I was thinking that maybe there could be a distinct constraint that takes a string template and makes sure that the string is unique always. Then you could put in whatever template string you want and it would make sure that it was always distinct.

Such as "${attr.platform.aws.placement.availability-zone}"

@jpbetz
Copy link

jpbetz commented Mar 3, 2017

@armon I have a similar need. I've plugged in a ${attr.platform.linkedin.rack} property via a custom env_*.go extension that I'd like to use both for rack diversity and affinity. I may add additional availability-zones in the future, but I need some way to constrain by them when scheduling for them to have any value.

@camerondavison
Copy link
Contributor Author

What do you think the level of work for this is? Something I need to leave to the core team or something I could look into?

@dadgar
Copy link
Contributor

dadgar commented Mar 6, 2017

Hey @jpbetz, make sense. I am curious is this long term ask or something you need in the immediate future?

@jpbetz
Copy link

jpbetz commented Mar 8, 2017 via email

@dadgar
Copy link
Contributor

dadgar commented Mar 9, 2017

@jpbetz Going to sneak it into Nomad 0.5.5! It is a cool feature and would love to help you all out on your POC where possible 👍

@jpbetz
Copy link

jpbetz commented Mar 10, 2017

Thanks @dadgar! For POC agility, we build and deploy Nomad from source. So it doesn't matter to me if this feature is in a point release or not, all I need is to know the commit hash and I'll pull from upstream to grab it.

@dadgar
Copy link
Contributor

dadgar commented Mar 13, 2017

@jpbetz Let me know if you run into any hiccups!

@jpbetz
Copy link

jpbetz commented Mar 14, 2017

@dadgar Go build fails on master using go 1.7.1 - 1.7.3 with:

src/github.com/hashicorp/nomad/helper/tlsutil/config.go:157: tlsConfig.Clone undefined (type *tls.Config has no field or method Clone, but does have tls.clone)

Having trouble finding a good go version to build with. What do you recommend?

@jpbetz
Copy link

jpbetz commented Mar 14, 2017

Nevermind, was able to build with 1.8.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants